Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker setup: docker compose without testing app #5839

Merged

Conversation

szobov
Copy link
Contributor

@szobov szobov commented Sep 3, 2024

Summary

Hey there,

Thanks for making such an excellent self-hosted traceability platform! 💪

I wanted to adopt SigNoz, but I faced an issue because I needed to use a vendor docker-compose file when I didn't need a test application.

Current documentation proposes commenting out these services in docker-compose.yaml.

Since docker-compose supports include command, we can overcome the need to edit existing code and also remove code duplication 🔪

I preserved the existing interfaces, so:
docker compose -f docker/clickhouse-setup/docker-compose.yaml up -d, would run the same set of services (with the testing app).

The interface that was added is:
docker compose -f docker/clickhouse-setup/docker-compose-minimal.yaml up -d, which won't run testing app.

Please let me know if you like it, and then I can update the documentation.
I'm looking forward to your comments!

@szobov szobov requested a review from a team as a code owner September 3, 2024 11:37
Copy link

welcome bot commented Sep 3, 2024

Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗

@CLAassistant
Copy link

CLAassistant commented Sep 3, 2024

CLA assistant check
All committers have signed the CLA.

prashant-shahi
prashant-shahi previously approved these changes Sep 27, 2024
@grandwizard28
Copy link
Collaborator

Hi @szobov,
Thanks for opening a PR here! Can you please resolve the merge conflicts?

@szobov
Copy link
Contributor Author

szobov commented Oct 4, 2024

Hey @grandwizard28
Thanks for your comment.
I'll resolve conflicts now, but it's very unfortunate that it took so long to get your attention.
Solving such conflicts is a bit painful because I'm not constantly following all the updates in this repo, and now I have to make sure that I don't miss anything due to conflict resolution.
I hope you can give this PR a little bit more attention after I solve the merge conflicts.
Thanks 🙏

@grandwizard28
Copy link
Collaborator

Hey @szobov,
This looks good!

You can proceed with updating the documentation here: https://signoz.io/docs/operate/docker-standalone/#remove-the-sample-application-from-signoz-dashboard

szobov added a commit to szobov/signoz-web that referenced this pull request Oct 7, 2024
Application from SigNoz Dashboard" section

The new section is "Running SigNoz without Sample Application".
It reflects changes made in SigNoz/signoz#5839
@szobov
Copy link
Contributor Author

szobov commented Oct 7, 2024

Hey @grandwizard28

Thanks for the heads up!
I created a PR with documentation changes and linked it to this one.
Could you please have a look 🙏
Many thanks.

@grandwizard28 grandwizard28 merged commit 76e7de3 into SigNoz:develop Oct 7, 2024
12 of 15 checks passed
Copy link

welcome bot commented Oct 7, 2024

Congrats on merging your first pull request!
minion-party
We here at SigNoz are proud of you! 🥳

grandwizard28 pushed a commit to SigNoz/signoz-web that referenced this pull request Oct 7, 2024
)

Application from SigNoz Dashboard" section

The new section is "Running SigNoz without Sample Application".
It reflects changes made in SigNoz/signoz#5839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants