feat: create menu items is added in the service application widgets #3358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
YounixM
previously approved these changes
Aug 17, 2023
Rajat-Dabade
previously approved these changes
Sep 7, 2023
|
@palashgdev, there is one issue that should be fixed. When there is more than one enabled query/formula, we need to ask the user to select one of them to create an alert. For instance, the latency chart has p50, p95, and p99; the user should be asked to select one and then redirected to the alert page with the selected data. This is important because an alert can't be created for pXX, and pYY at the same time. |
|
This is not shippable @palashgdev. We put it on hold because of a top-level operations issue. We only need to allow the creation of alerts from dashboards for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the option of creating alerts in the metrics application widgets
Screen.Recording.2023-08-17.at.11.57.13.AM.mov
part of #2255