Skip to content

Commit

Permalink
chore: comments for side nav issues
Browse files Browse the repository at this point in the history
  • Loading branch information
vikrantgupta25 committed Dec 4, 2024
1 parent 43f856c commit 71f32f0
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions frontend/src/container/SideNav/SideNav.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ function SideNav({
}, [featureResponse.data]);

// using a separate useEffect as the license fetching call takes few milliseconds
// when initially there is no licenses call and the role has also been set then billing will be wiped away from menu items and never come back!
useEffect(() => {
if (!isFetching) {
let items = [...menuItems];
Expand Down Expand Up @@ -232,6 +233,7 @@ function SideNav({
pathname,
]);

// there will be a race condition between the useEffect on line 95 which is setting userManagementMenuItems as well!
useEffect(() => {
if (isCloudUser() || isEECloudUser()) {
const updatedUserManagementMenuItems = [helpSupportMenuItem];
Expand Down

0 comments on commit 71f32f0

Please sign in to comment.