chore: scrape normalized_query_hash as string value instead of uint64 from system.query_log table #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from system.query_log table
raj-k-singh
requested review from
ankitnayan,
makeavish,
nityanandagohain,
prashant-shahi and
srikanthccv
as code owners
srikanthccv
approved these changes
May 15, 2024
nityanandagohain
approved these changes
May 15, 2024
raj-k-singh
deleted the
chore/clickhouse-query-log-receiver-str-normalized-query-hash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the clickhousesystemtablesreceiver scrapes normalized_query_hash column from system.query_log table as a uint64 value, but the value ends up in int64 fields which leads to integer overflow (the logs table supports only int64 values and pdata also stores uints as ints )
Since the query hash is used only for equality comparisons, it should be scraped as a string value to preserve the original value
fixes #319