Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) return a default topic when tenant_id is not present #304

Merged
merged 2 commits into from
Mar 26, 2024
Merged

(feat) return a default topic when tenant_id is not present #304

merged 2 commits into from
Mar 26, 2024

Conversation

grandwizard28
Copy link
Collaborator

@grandwizard28 grandwizard28 commented Mar 21, 2024 •
edited
Loading

Features

  • Return a default topic name when signoz_tenant_id is missing in the metadata

Refactors

  • Change name of the function getKafkaTopicPrefixFromClientMetadata to reflect what it is actually doing.

@grandwizard28
(refactor) rename the function to getKafkaTopicPrefixFromClientMetada…
a47a7ed 
…ta making it consistent with what the function is doing
@srikanthccv srikanthccv merged commit 539b6be into main Mar 26, 2024
3 checks passed
@srikanthccv srikanthccv deleted the feature/default branch March 26, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@prashant-shahi prashant-shahi prashant-shahi approved these changes

@ankitnayan ankitnayan Awaiting requested review from ankitnayan

@makeavish makeavish Awaiting requested review from makeavish

@nityanandagohain nityanandagohain Awaiting requested review from nityanandagohain

@raj-k-singh raj-k-singh Awaiting requested review from raj-k-singh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grandwizard28 @prashant-shahi @srikanthccv