Chore: signozkafkaexporter: ensure log body is always a string #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sting signozkafkaexporter
raj-k-singh
force-pushed
the
chore/bytes-to-string-in-kafka-exporter
branch
from
68190ad
to
9c9b5af
Compare
raj-k-singh
requested review from
ankitnayan,
makeavish,
nityanandagohain,
prashant-shahi and
srikanthccv
as code owners
srikanthccv
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is very uncommon, log bodies are sent as bytes at times.
Most of the components used on the write path (eg: JSON parser in logtransform) expect log bodies to be string.
Also signozkafkaexporter converts log bodies to string before storing them in clickhouse.
This PR updates signozkafkaexporter to ensure log bodies exported to kafka always have string bodies, ensuring that components on the write path after signozkafkaexporter can work with string values in log bodies.
Addresses #301