Skip to content

Commit

Permalink
fix: don't drop actual duration sort table (#460)
Browse files Browse the repository at this point in the history
don't drop actual duration sort table
  • Loading branch information
nityanandagohain authored Nov 22, 2024
1 parent c5b5e27 commit ff4d557
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions cmd/signozschemamigrator/schema_migrator/traces_migrations.go
Original file line number Diff line number Diff line change
Expand Up @@ -423,14 +423,14 @@ var TracesMigrations = []SchemaMigrationRecord{
Database: "signoz_traces",
Table: "distributed_durationSort",
},
DropTableOperation{
Database: "signoz_traces",
Table: "durationSort",
// this is added so that we can avoid the following error
//1. Size (453.51 GB) is greater than max_[table/partition]_size_to_drop (50.00 GB)
// https://stackoverflow.com/questions/78162269/cannot-drop-large-materialized-view-in-clickhouse
Settings: TableSettings{{Name: "max_table_size_to_drop", Value: "0"}},
},
// DropTableOperation{
// Database: "signoz_traces",
// Table: "durationSort",
// // this is added so that we can avoid the following error
// //1. Size (453.51 GB) is greater than max_[table/partition]_size_to_drop (50.00 GB)
// // https://stackoverflow.com/questions/78162269/cannot-drop-large-materialized-view-in-clickhouse
// Settings: TableSettings{{Name: "max_table_size_to_drop", Value: "0"}},
// },
},
DownItems: []Operation{},
},
Expand Down

0 comments on commit ff4d557

Please sign in to comment.