Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unit-tests): run unit-tests in PR and fix failing tests #109

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

cedi
Copy link
Contributor

@cedi cedi commented Nov 29, 2024

Unit-tests should run for PRs and also fixing the failing unit-tests

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.73%. Comparing base (6803644) to head (b02a902).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   70.20%   69.73%   -0.47%     
==========================================
  Files          24       24              
  Lines        2034     2148     +114     
==========================================
+ Hits         1428     1498      +70     
- Misses        606      650      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@notheotherben notheotherben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, I suspect I'm going to need to also do some work on ensuring that our tests are invariant on changes made to a GitHub account 🤔.

@notheotherben notheotherben merged commit 2756c42 into SierraSoftworks:main Nov 29, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants