-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@types npm scope #47
Comments
Thanks for the heads up Phil, I'll take a look early next week and see what I can do to sort it out. Alternatively, if you're interested and have the time, I'd really appreciate a pull request with your suggested fixes on the 7.0.0-dev branch. Kind regards, |
So I'm trying to get the 7.0.0-dev branch working for developing... It seems to have run through on travis: https://travis-ci.org/SierraSoftworks/Iridium/builds/149098587 (which is weird) ...but when I check out the branch and do a simple
Could you try rerunning the build on travis, so I know wether its a problem with my environment or due to some npm @types/ package updates? Thanks :) |
Hi Phil, seeing the same on the Travis build, will take a look and fix it as soon as I get a chance. |
... the whole @types scope is a little bit messed up right now.... e.g: Everyone is starting to put |
Of course they are, I'll look at maybe shrinkwrapping things to make it a bit more predictable in future. |
well, yes, but the decent thing to do would be to have it as peer dependency and let the environment decide which node version is required... I actually made a little tool that takes care of that: It'll check for any present @types/node versions up front and will only add the right @types/node to the mix if no prior @types/node version (specified as dependency by some other @types/[anything] module) is found to avoid possible double definition typescript errors. |
ah, actually just read through shrinkwrapping. Honestly I somehow overlooked that possibility until now... awesome! :) |
It's a great solution to the problem, assuming of course that you can find versions of the libraries which work... Would be great if MS would put together a unified set of best practices for module creators, unfortunately there's so many conflicting approaches which all cause their fair share of problems. |
Managed to fix the issues you're seeing without needing to resort to hacky solutions, let me know if you run into issues |
Hi,
awesome that you are using the new @types scope typings. It makes using iridium a breeze without having to postinstall typings dependencies. 👍
Here are some additional thoughts regarding the fairly new @types scope:
0.0.x
notation for all @types scoped packages that are below0.1.0
as^
will cause unpredictable behaviour in my experience for the below0.1.0
version range.Regards
Phil
The text was updated successfully, but these errors were encountered: