Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace copied code and submodules for Swift PM versions of Roxas and SideKit #278

Closed
wants to merge 34 commits into from

Conversation

JoeMatt
Copy link
Member

@JoeMatt JoeMatt commented Feb 25, 2023

  • Local files that were copied from AltKit were removed.
  • Replace Roxas submodule with JoeMatt/Roxas swift package.
  • Add SideStore/SideKit swift package from this PR aka branch 'feature/swiftall'
  • Added explicit generic constraints to ConnectionManager for ConnectionType and ConnectionHanderType where ConnectionHanderType.ConnectionType == ConnectionType. This resolves some warnings and compiler fuckery not knowing how to type check some things. Also remove needing to use any Connectoin in newer XCodes.
  • Fixed various warning/deprecations
  • Update AltSign to not include libplist,
  • Made a new repo call iMobiledevice.swfit to wrap libusbmuxd, libplist, libimobiledevice etc
  • SideStore and AltSign now use that library to avoid duplication
  • Converted all app and app library objetive-c to swift
  • Converted whole app and frameworks, widget etc to swift packages (xcode or tuist still needed since swift pm is stlll dumb with info.plist etc)
  • Added new xcodeplugins to auto generate a number of things including os.logger include and Logger domain for app and IntentBuilder to add swift pm support for finding classes in .intentdefinition files in new repo JoeMatt/SPMPlugins
  • Some general clean up in some spots with force unwraps, unhandlede errors
  • Fixed a lot of riley's annoying swift formatting
if this
{
...
}
else 
{
...
}

is not the proper apple swift formatting lines

if this {
} else {
}

Also added a .editorconfig, .swiftlint and .swiftformat.yml files to avoid conflicts in the future

  • updated em_proxy and minimuxer repos to build .xcframework.zip files whenever you push a commit with [build] message. No more weird local script

  • Added em_proxy and minimuxer Makefile to make it easier to build
    make build, make xcframework and make zip will do build static, then static to xcfraomework, finally a zipped version. This isi what the repo's gh action is using

  • Added an xcplugin that makes a swift files with the git commit, date etc so it can be printed into Settings etc

  • Convert all printf to os_log so we can actually see wtf is going on with and fix the bugs outstanding

TODO:
Finish the .xcodeproj spm wrapp

@JoeMatt JoeMatt requested a review from lonkelle as a code owner February 25, 2023 06:41
@JoeMatt JoeMatt force-pushed the feature/RoxasAndSideKitPackages branch from b07c93c to 52eac79 Compare March 2, 2023 00:46
@Spidy123222
Copy link
Member

Since this has stuff about sidekit will my changes be added to this or be separated. #282

@JoeMatt JoeMatt force-pushed the feature/RoxasAndSideKitPackages branch from 3fe2343 to 128b180 Compare March 11, 2023 00:33
Signed-off-by: Joseph Mattello <[email protected]>
@Spidy123222 Spidy123222 added the help wanted Extra attention is needed label May 18, 2023
@SternXD
Copy link
Member

SternXD commented Apr 24, 2024

What's the current status of this Pull Request?

@JoeMatt JoeMatt self-assigned this Jun 23, 2024
@JoeMatt JoeMatt marked this pull request as draft June 23, 2024 03:26
@Spidy123222
Copy link
Member

What's the current status of this Pull Request?

Currently we have a SideKIT spm which should be fine. This prices stale currently

@JoeMatt JoeMatt closed this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend conflict help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants