Fix #14. Build fails with [email protected]

[doochik]

"Argument 0 (NSNumber) of RCTRefreshControl.configure has unspecified nullability but React requires that all NSNumber arguments are explicitly marked as nonnull to ensure compatibility with Android."

[christoph-jerolimov]

👍

[JonathanWi]

I want to use your fix in my project, but when I replace the git url with https://github.com/doochik/RCTRefreshControl.git#43de75405a4fa3b6450398933b306fa5832a223e , everything works except it doesn't import ODRefreshControl... Any idea @doochik ?

[doochik]

@JonathanWi Hi! I think you should make git submodule update --init because ODRefreshControl is imported as git submodule (https://github.com/Shuangzuan/RCTRefreshControl/blob/master/.gitmodules)

[JonathanWi]

Hey @doochik ! Thanks a lot for your fast answer! Just tried your solution (even automated it via scripts in my package.json)

"scripts": {
     "postinstall": "git submodule update --init"
 }

but that doesn't seem to work either...

Any other idea? Thanks a lot for your time

[doochik]

@JonathanWi Sorry you can't do it with npm and package.json :(
I usually clone my fork and run git submodule update --init from console.

I've write the email to @Shuangzuan and ask him to merge my PR and publish new version to npm.

[JonathanWi]

Awesome, thanks a lot @doochik

[rreusser]

👍 Ended up just hard-coding the fix since submodule whatnot. Merged PR would be outstanding!

[rreusser]

Thanks for the merge. Seems it needs an npm publish too, right?

[rpastorelle]

@Shuangzuan Can you npm publish so we can use this PR 😃

[rreusser]

@rpastorelle: I applied exactly this PR and flattened (i.e. un-submoduled) the submodule. If you just need a quick fix, you can use the version at https://github.com/rreusser/RCTRefreshControl by adding to your package.json:

"react-refresh-control": "git://github.com/rreusser/RCTRefreshControl.git#4626f01d2c5730baf090d262aaf93076c9773f59",

(I know that's not a long-term solution, but maybe it's a reasonable quick-fix if that's all you need 😄 )

[AdamBrodzinski]

@Shuangzuan is there anything I can do do help publish this fix to NPM? I just reinstalled and have the same issue. Using the git checkout like @rreusser mentioned works but is not ideal.

[rreusser]

I'd be glad to merge what I have and be a maintainer if added to the repo and npm. I think it's purely just small maintenance fixes that are causing the problems here.