Skip to content

Commit

Permalink
Fix #14. Build fails with [email protected]
Browse files Browse the repository at this point in the history
"Argument 0 (NSNumber) of RCTRefreshControl.configure has unspecified nullability but React requires that all NSNumber arguments are explicitly marked as `nonnull` to ensure compatibility with Android."
  • Loading branch information
doochik committed Sep 4, 2015
1 parent dcdf0d0 commit 43de754
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions RCTRefreshControl.m
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ - (dispatch_queue_t)methodQueue {
return self.bridge.uiManager.methodQueue;
}

RCT_EXPORT_METHOD(configure:(NSNumber *)reactTag
RCT_EXPORT_METHOD(configure:(nonnull NSNumber *)reactTag
options:(NSDictionary *)options
callback:(RCTResponseSenderBlock)callback) {
[self.bridge.uiManager addUIBlock:^(RCTUIManager *uiManager, RCTSparseArray *viewRegistry) {
Expand Down Expand Up @@ -50,7 +50,7 @@ - (dispatch_queue_t)methodQueue {
}];
}

RCT_EXPORT_METHOD(beginRefreshing:(NSNumber *)reactTag) {
RCT_EXPORT_METHOD(beginRefreshing:(nonnull NSNumber *)reactTag) {
[self.bridge.uiManager addUIBlock:^(RCTUIManager *uiManager, RCTSparseArray *viewRegistry) {

UIView *view = viewRegistry[reactTag];
Expand All @@ -69,7 +69,7 @@ - (dispatch_queue_t)methodQueue {
}];
}

RCT_EXPORT_METHOD(endRefreshing:(NSNumber *)reactTag) {
RCT_EXPORT_METHOD(endRefreshing:(nonnull NSNumber *)reactTag) {
[self.bridge.uiManager addUIBlock:^(RCTUIManager *uiManager, RCTSparseArray *viewRegistry) {

UIView *view = viewRegistry[reactTag];
Expand Down

0 comments on commit 43de754

Please sign in to comment.