This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Add support ruby 250 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 10, 2018 17:06
Grpc was being kept at 1.6.0, which does not support ruby 2.5.0. Since that important for us, update to 1.17.0 and solve issue with deadline in spec by using `#from_relative_time` provided by `GRPC::Core::TimeConsts` instead of our own implementation. Also provide rake file with task to download etcd and improve travis config to test more configurations.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for ruby 2.5.0 with working spec.
Davide please take a look and merge if looks ok.