check if reply result is already decoded #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshJuncker
approved these changes
May 29, 2022
|
Good find. Weird because I'm using AppLinks in my project as well and have not run into this issue. But the code is harmless nonetheless, so if it solves some issues, then great! |
Saadali-Social
pushed a commit
to thesocialapp/share_handler
that referenced
this pull request
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some conflicts when using with other packages. I have not been able to debug this to find the root cause but in my project there was an error that the SharedMedia was being decoded twice when getting initial media. The same problem was mentioned here: #3 This checks the incomming result and if it is already SharedMedia type it returns instead of decoding.