Fixes #17 for shared view controller in ios that has non public methods.

ShoutSocial · Jul 18, 2022 · 700834b · 700834b
1 parent ab5630f
commit 700834b
Show file tree

Hide file tree

Showing 7 changed files with 19 additions and 15 deletions.
diff --git a/share_handler/CHANGELOG.md b/share_handler/CHANGELOG.md
@@ -1,3 +1,5 @@
+# 0.0.16
+Fix for non public methods in inherited viewcontroller for iOS
 # 0.0.15
 Updated Readme for custom group id for the runner target
 # 0.0.14

diff --git a/share_handler/pubspec.yaml b/share_handler/pubspec.yaml
@@ -1,7 +1,7 @@
 name: share_handler
 description: A Flutter plugin to handle incoming shared text/media, as well as add share to suggestions/shortcuts.
 repository: https://github.com/AboutShout/share_handler/tree/main/share_handler
-version: 0.0.15
+version: 0.0.16
 
 environment:
   sdk: ">=2.14.0 <3.0.0"
@@ -29,7 +29,7 @@ dependencies:
   share_handler_android: ^0.0.6
   # share_handler_android:
   #   path: ../share_handler_android
-  share_handler_ios: ^0.0.8
+  share_handler_ios: ^0.0.9
   # share_handler_ios:
   #   path: ../share_handler_ios
   # share_handler_linux:

diff --git a/share_handler_ios/CHANGELOG.md b/share_handler_ios/CHANGELOG.md
@@ -1,3 +1,5 @@
+# 0.0.9
+Fix for non public methods in inherited viewcontroller
 # 0.0.8
 Setup podspecs and dependencies better
 # 0.0.7

diff --git a/share_handler_ios/ios/Models/Classes/ShareHandlerIosViewController.swift b/share_handler_ios/ios/Models/Classes/ShareHandlerIosViewController.swift
@@ -34,7 +34,7 @@ open class ShareHandlerIosViewController: SLComposeServiceViewController {
         return true
     }
 
-    private func loadIds() {
+    public func loadIds() {
             // loading Share extension App Id
             let shareExtensionAppBundleIdentifier = Bundle.main.bundleIdentifier!;
 
@@ -101,14 +101,14 @@ open class ShareHandlerIosViewController: SLComposeServiceViewController {
         return []
     }
 
-    private func getNewFileUrl(fileName: String) -> URL {
+    public func getNewFileUrl(fileName: String) -> URL {
         let newFileUrl = FileManager.default
             .containerURL(forSecurityApplicationGroupIdentifier: ShareHandlerIosViewController.appGroupId)!
             .appendingPathComponent(fileName)
         return newFileUrl
     }
 
-    private func handleText (content: NSExtensionItem, attachment: NSItemProvider, index: Int) async throws {
+    public func handleText (content: NSExtensionItem, attachment: NSItemProvider, index: Int) async throws {
         let data = try await attachment.loadItem(forTypeIdentifier: textContentType, options: nil)
 
         if let item = data as? String {
@@ -119,7 +119,7 @@ open class ShareHandlerIosViewController: SLComposeServiceViewController {
 
     }
 
-    private func handleUrl (content: NSExtensionItem, attachment: NSItemProvider, index: Int) async throws {
+    public func handleUrl (content: NSExtensionItem, attachment: NSItemProvider, index: Int) async throws {
         let data = try await attachment.loadItem(forTypeIdentifier: urlContentType, options: nil)
 
             if let item = data as? URL {
@@ -130,7 +130,7 @@ open class ShareHandlerIosViewController: SLComposeServiceViewController {
 
     }
 
-    private func handleImages (content: NSExtensionItem, attachment: NSItemProvider, index: Int) async throws {
+    public func handleImages (content: NSExtensionItem, attachment: NSItemProvider, index: Int) async throws {
         let data = try await attachment.loadItem(forTypeIdentifier: imageContentType, options: nil)
 
         var fileName: String?
@@ -179,7 +179,7 @@ open class ShareHandlerIosViewController: SLComposeServiceViewController {
 
     }
 
-    private func handleVideos (content: NSExtensionItem, attachment: NSItemProvider, index: Int) async throws {
+    public func handleVideos (content: NSExtensionItem, attachment: NSItemProvider, index: Int) async throws {
         let data = try await attachment.loadItem(forTypeIdentifier: movieContentType, options: nil)
 
 
@@ -198,7 +198,7 @@ open class ShareHandlerIosViewController: SLComposeServiceViewController {
 
     }
 
-    private func handleFiles (content: NSExtensionItem, attachment: NSItemProvider, index: Int) async throws {
+    public func handleFiles (content: NSExtensionItem, attachment: NSItemProvider, index: Int) async throws {
         let data = try await attachment.loadItem(forTypeIdentifier: fileURLType, options: nil)
 
         if let url = data as? URL {
@@ -216,7 +216,7 @@ open class ShareHandlerIosViewController: SLComposeServiceViewController {
 
     }
 
-    private func handleData (content: NSExtensionItem, attachment: NSItemProvider, index: Int) async throws {
+    public func handleData (content: NSExtensionItem, attachment: NSItemProvider, index: Int) async throws {
         let data = try await attachment.loadItem(forTypeIdentifier: dataContentType, options: nil)
 
         if let url = data as? URL {
@@ -234,7 +234,7 @@ open class ShareHandlerIosViewController: SLComposeServiceViewController {
 
     }
 
-    private func dismissWithError() {
+    public func dismissWithError() {
         print("[ERROR] Error loading data!")
         let alert = UIAlertController(title: "Error", message: "Error loading data", preferredStyle: .alert)
 
@@ -247,7 +247,7 @@ open class ShareHandlerIosViewController: SLComposeServiceViewController {
         extensionContext!.completeRequest(returningItems: [], completionHandler: nil)
     }
 
-    private func redirectToHostApp() {
+    public func redirectToHostApp() {
         // ids may not loaded yet so we need loadIds here too
         loadIds();
         let url = URL(string: "ShareMedia-\(ShareHandlerIosViewController.hostAppBundleIdentifier)://\(ShareHandlerIosViewController.hostAppBundleIdentifier)?key=\(sharedKey)")

diff --git a/share_handler_ios/ios/Models/share_handler_ios_models.podspec b/share_handler_ios/ios/Models/share_handler_ios_models.podspec
@@ -4,7 +4,7 @@
 #
 Pod::Spec.new do |s|
   s.name             = 'share_handler_ios_models'
-  s.version          = '0.0.8'
+  s.version          = '0.0.9'
   s.summary          = 'Shared code for share_handler_ios plugin.'
   s.description      = <<-DESC
   Shared code for share_handler_ios plugin so main app and share extension targets can use it.

diff --git a/share_handler_ios/ios/share_handler_ios.podspec b/share_handler_ios/ios/share_handler_ios.podspec
@@ -4,7 +4,7 @@
 #
 Pod::Spec.new do |s|
   s.name             = 'share_handler_ios'
-  s.version          = '0.0.8'
+  s.version          = '0.0.9'
   s.summary          = 'iOS implementation of the share_handler plugin.'
   s.description      = <<-DESC
   iOS implementation of the share_handler plugin.

diff --git a/share_handler_ios/pubspec.yaml b/share_handler_ios/pubspec.yaml
@@ -1,7 +1,7 @@
 name: share_handler_ios
 description: An implementation for the iOS platform of the Flutter share_handler plugin.
 repository: https://github.com/AboutShout/share_handler/tree/main/share_handler_ios
-version: 0.0.8
+version: 0.0.9
 
 environment:
   sdk: ">=2.14.0 <3.0.0"