Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v19.0.8-shopify-1 #207

Open
wants to merge 8 commits into
base: v19.0.8-shopify-1
Choose a base branch
from
Open

v19.0.8-shopify-1 #207

wants to merge 8 commits into from
+923 −218

Conversation

shanth96
Copy link 

dev new_version_from_upstream 19.0.8 
🔧  Running ruby version_builder_v2.rb --version from dev.yml
Ignoring eventmachine-1.2.7 because its extensions are not built. Try: gem pristine eventmachine --version 1.2.7
Using previous Shopify release: v19.0.5-shopify-3
The following commits are necessary for upstream version 19.0.8:
2b4f95038d09734d69ffa1539175fcac9ceb8b35, PR: 146
c0eeea88b09618f101c616923efc386b76457b52, PR: 102
1435f6fa8923cdaf21782882f175f9d68091b97c, PR: 148
bb561e38677d386cc9cdf1323be2a60673116160, PR: 161
437b9861232451f0a83becfc8cbc4fb3ac3e66ec, PR: 164
1b71895dba15cf53c6ffc786143f6bb60abaaa8d, PR: 175
59f9a19ccbe6c87491455f57ecdce6ffae163460, PR: 180
17ebe6f7219bab24e752ab24ce762cb1c535a569, PR: 182

git cherry-pick -x 2b4f95038d09734d69ffa1539175fcac9ceb8b35
git cherry-pick -x -m 1 c0eeea88b09618f101c616923efc386b76457b52
git cherry-pick -x -m 1 1435f6fa8923cdaf21782882f175f9d68091b97c
git cherry-pick -x -m 1 bb561e38677d386cc9cdf1323be2a60673116160
git cherry-pick -x -m 1 437b9861232451f0a83becfc8cbc4fb3ac3e66ec
git cherry-pick -x -m 1 1b71895dba15cf53c6ffc786143f6bb60abaaa8d
git cherry-pick -x -m 1 59f9a19ccbe6c87491455f57ecdce6ffae163460
git cherry-pick -x -m 1 17ebe6f7219bab24e752ab24ce762cb1c535a569

jeremycole and others added 4 commits January 14, 2025 10:25
@jeremycole @shanth96
Add new placement Vindex strategy
956625a 
Signed-off-by: Jeremy Cole <[email protected]>

Sprinkle addPadding everywhere when comparing KeyRange Start/End values

Implement support for PartialVindex usage

Signed-off-by: Jeremy Cole <[email protected]>
(cherry picked from commit 7424fff)
(cherry picked from commit 69e6248)
(cherry picked from commit 8390560)
(cherry picked from commit b0cad30)
(cherry picked from commit a9b168b)
(cherry picked from commit 2b4f950)
@brendar @shanth96
Merge pull request #102 from Shopify/generate-cachedsize-for-placemen…
1da46b4 
…t-vindex

Generate CachedSize function for Placement vindex

(cherry picked from commit 986ffc6)
(cherry picked from commit 1fe7126)
(cherry picked from commit 62a60b2)
(cherry picked from commit f258063)
(cherry picked from commit 448060c)
(cherry picked from commit c0eeea8)
@shanth96
Merge pull request #148 from Shopify/fix-tests
00fde9e 
Run all relevant tests on all PRs

(cherry picked from commit b55dd26)
(cherry picked from commit 8feee14)
(cherry picked from commit 6bc3c08)
(cherry picked from commit 33b5962)
(cherry picked from commit a7ad1c7)
(cherry picked from commit 1435f6f)
@shivnagarajan @shanth96
Merge pull request #161 from Shopify/fix_e2e_test_v17
09f22ba 
fix for e2e test issue on v17

(cherry picked from commit 6a86fc9)
(cherry picked from commit a4df282)
(cherry picked from commit a313528)
(cherry picked from commit bb561e3)
@shanth96 shanth96 force-pushed the v19.0.8-shopify-1-candidate branch 4 times, most recently from 85ed603 to f745536 Compare January 17, 2025 16:37
shivnagarajan and others added 4 commits January 20, 2025 11:03
@shivnagarajan @shanth96
Merge pull request #164 from Shopify/fix_tests_for_v18
fa7ffa3 
fix tests for CI

(cherry picked from commit aa73e7f)
(cherry picked from commit bc37e52)
(cherry picked from commit 437b986)
@brendar @shanth96
Merge pull request #175 from Shopify/v19.0.4-shopify-2-candidate-back…
fa93515 
…port-vtcombo-vschema

Backport: VTCombo: Ensure VSchema exists when creating keyspace (vitessio#16094)
(cherry picked from commit 4b24c58)
(cherry picked from commit 1b71895)
@shanth96
Merge pull request #180 from Shopify/fix-workflows
95fb58a 
Run vtgate workflows on ubuntu and remove assign milestone

(cherry picked from commit 59f9a19)
@brendar @shanth96
Merge pull request #182 from Shopify/v19.0.5-shopify-2-backport-vtcom…
70c334f 
…bo-conn-leak

Backport: vtcombo: close query service on drop database
(cherry picked from commit 17ebe6f)
@shanth96 shanth96 force-pushed the v19.0.8-shopify-1-candidate branch from f745536 to 70c334f Compare January 20, 2025 16:03
@shanth96 shanth96 requested review from jgnagy and brendar January 21, 2025 19:24
jgnagy
jgnagy approved these changes Jan 22, 2025
View reviewed changes
Copy link

@jgnagy jgnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem possible to actually review all these changes but... approved!

brendar
brendar approved these changes Jan 24, 2025
View reviewed changes
Copy link

@brendar brendar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Reviewed by looking at the patches applied to our previous v19 release

git log --oneline --graph v19.0.5..origin/v19.0.5-shopify-3

And the patches applied to this release

git log --oneline --graph v19.0.8..origin/v19.0.8-shopify-1-candidate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendar brendar brendar approved these changes

@jgnagy jgnagy jgnagy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shanth96 @jgnagy @brendar @jeremycole @shivnagarajan