Backport upstream schema_version corruption fix #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austenLacy
force-pushed
the
austenlacy/vitess-project-488/merge-upstream-pr-13045
branch
2 times, most recently
from
13c559e to
2b2e7b9
Compare
brendar
reviewed
Jun 20, 2023
This change is purely defensive, but it may help avoid future race conditions caused by modifying shared schema structs while they are being marshaled to protobuf. Signed-off-by: Brendan Dougherty <[email protected]>
austenLacy
force-pushed
the
austenlacy/vitess-project-488/merge-upstream-pr-13045
branch
from
2b2e7b9 to
bf09bf7
Compare
brendar
approved these changes
Jun 21, 2023
austenLacy
deleted the
austenlacy/vitess-project-488/merge-upstream-pr-13045
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back-port of vitessio#13045