This repository has been archived by the owner on Feb 20, 2021. It is now read-only.
Tweaking Travis for Green #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you get a 👍 from me if it's green. Thanks for jumping in on this - I was gonna go down a very different rabbit hole. |
|
🍏 CI again! |
|
🚢 |
kyrylo
added a commit
to airbrake/airbrake-ruby
that referenced
this pull request
Mar 10, 2016
Fixes NoMethodError bug on Circle CI See: https://circleci.com/gh/airbrake/airbrake-ruby/199 Reported here: rubygems/bundler#3558 Fix inspired by: Shopify/verdict#17
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ohsabry @wvanbergen
The Problem
There was an issue in bundler the causes a NoMethodError (spec undefined for nil:NilClass). It looks like recent versions of ruby on travis are ok, but 1.9.3 needs to update bundler before installing (see this PR for details ~ April 2015).
The Solution
Tell travis to update bundler before installing. I've also cached bundles for faster CI runs (auto updates if the bundle is updated).