Skip to content
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

theme-check with onlySingleFileChecks reports fixed "full check" errors #570

Closed
vfonic opened this issue Feb 26, 2022 · 0 comments · Fixed by #624
Closed

theme-check with onlySingleFileChecks reports fixed "full check" errors #570

vfonic opened this issue Feb 26, 2022 · 0 comments · Fixed by #624
Assignees
@charlespwd
Labels
bug Something isn't working language server Language Server related issues

Comments

@vfonic
Copy link

vfonic commented Feb 26, 2022 •
edited
Loading

Related: theme-check reports "full theme check" errors on removed files #569

Repro steps:

  1. Open VS Code settings JSON and set: "themeCheck.onlySingleFileChecks": true,
  2. Open theme.liquid (this is the easiest)
  3. Add {{ 'unknown_variable' | t }} right below <head> (anywhere really, but my screenshots show this location)
  4. Run: >Liquid Theme Check: Run Checks
  5. See the error was created:
    Screen Shot 2022-02-26 at 12 11 37
  6. Delete the whole line of code that added the error.

Expected:

The error goes away

Actual:

The error underline stays at the same place where the error was before deletion.

Screen Shot 2022-02-26 at 12 11 46

The error goes away when running >Liquid Theme Check: Run Checks again.
@charlespwd charlespwd added the bug Something isn't working label Mar 30, 2022
@charlespwd charlespwd transferred this issue from Shopify/theme-check-vscode Mar 30, 2022
@charlespwd charlespwd assigned charlespwd and unassigned charlespwd Jun 2, 2022
@charlespwd charlespwd added the language server Language Server related issues label Jul 13, 2022
charlespwd added a commit that referenced this issue Jul 28, 2022
@charlespwd
Make runChecks command respect onlySingleFileChecks
642d068 
Logic was wrong.

When onlySingleFileChecks is on and someone executes the `runChecks`
command. We should do the following:

- Run checks for opened files
- Update diagnostics from opened files
- Do not show "whole theme checks"

Fixes #570
@charlespwd charlespwd mentioned this issue Jul 28, 2022
Merged
charlespwd added a commit that referenced this issue Jul 29, 2022
@charlespwd
Make runChecks command respect onlySingleFileChecks (#624)
3963b2c 
Logic was wrong.

When onlySingleFileChecks is on and someone executes the `runChecks`
command. We should do the following:

- Run checks for opened files
- Update diagnostics from opened files
- Do not show "whole theme checks"

Fixes #570
@charlespwd charlespwd self-assigned this Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@charlespwd charlespwd

Labels
bug Something isn't working language server Language Server related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make runChecks command respect onlySingleFileChecks Shopify/theme-check
2 participants
@vfonic @charlespwd