Skip to content
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

Problem with theme watch on themes with gem pages page builder app #348

Closed
AngelikaBlend opened this issue Jul 6, 2021 · 1 comment · Fixed by #350
Closed

Problem with theme watch on themes with gem pages page builder app #348

AngelikaBlend opened this issue Jul 6, 2021 · 1 comment · Fixed by #350
Assignees
@macournoyer

Comments

@AngelikaBlend
Copy link

Checking . ... Exception while running SpaceInsideBraces#on_variable`:

ArgumentError: Offense markup cannot be an empty string
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/offense.rb:34:in `initialize'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/check.rb:84:in `new'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/check.rb:84:in `add_offense'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/checks/space_inside_braces.rb:56:in `on_variable'      
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/checks.rb:33:in `block in call_check_method'
  C:/Ruby27-x64/lib/ruby/2.7.0/timeout.rb:95:in `block in timeout'
  C:/Ruby27-x64/lib/ruby/2.7.0/timeout.rb:33:in `block in catch'
  C:/Ruby27-x64/lib/ruby/2.7.0/timeout.rb:33:in `catch'
  C:/Ruby27-x64/lib/ruby/2.7.0/timeout.rb:33:in `catch'
  C:/Ruby27-x64/lib/ruby/2.7.0/timeout.rb:110:in `timeout'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/checks.rb:32:in `call_check_method'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/checks.rb:11:in `block in call'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/checks.rb:10:in `each'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/checks.rb:10:in `call'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:35:in `call_checks'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:23:in `visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `block in visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `each'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `block in visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `each'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `block in visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `each'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `block in visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `each'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `block in visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `each'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `block in visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `each'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `block in visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `each'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `block in visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `each'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `block in visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `each'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `block in visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `each'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `block in visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `each'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `block in visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `each'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `block in visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `each'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `block in visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `each'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `block in visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `each'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:24:in `visit'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/visitor.rb:12:in `visit_template'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/analyzer.rb:38:in `block in analyze_theme'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/analyzer.rb:37:in `each'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/analyzer.rb:37:in `analyze_theme'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/cli.rb:157:in `check'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/cli.rb:97:in `run!'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/theme-check-1.0.0/lib/theme_check/cli.rb:101:in `run'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/lib/project_types/theme/commands/check.rb:25:in `call'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/lib/shopify-cli/sub_command.rb:13:in `call'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/lib/shopify-cli/command.rb:19:in `call'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/vendor/deps/cli-kit/lib/cli/kit/executor.rb:16:in `block (2 levels) in 
call'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/vendor/deps/cli-kit/lib/cli/kit/executor.rb:37:in `block (2 levels) in 
with_logging'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/vendor/deps/cli-ui/lib/cli/ui/stdout_router.rb:169:in `with_id'        
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/vendor/deps/cli-kit/lib/cli/kit/executor.rb:36:in `block in with_logging'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/vendor/deps/cli-ui/lib/cli/ui.rb:176:in `log_output_to'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/vendor/deps/cli-kit/lib/cli/kit/executor.rb:35:in `with_logging'       
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/vendor/deps/cli-kit/lib/cli/kit/executor.rb:15:in `block in call'      
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/vendor/deps/cli-kit/lib/cli/kit/executor.rb:45:in `block (2 levels) in 
with_traps'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/vendor/deps/cli-kit/lib/cli/kit/executor.rb:51:in `twrap'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/vendor/deps/cli-kit/lib/cli/kit/executor.rb:44:in `block in with_traps'  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/vendor/deps/cli-kit/lib/cli/kit/executor.rb:51:in `twrap'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/vendor/deps/cli-kit/lib/cli/kit/executor.rb:43:in `with_traps'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/vendor/deps/cli-kit/lib/cli/kit/executor.rb:14:in `call'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/lib/shopify-cli/core/executor.rb:15:in `call'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/lib/shopify-cli/core/entry_point.rb:24:in `block in call'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/lib/shopify-cli/core/monorail.rb:32:in `log'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/lib/shopify-cli/core/entry_point.rb:23:in `call'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/bin/shopify:33:in `block in <main>'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/vendor/deps/cli-kit/lib/cli/kit/error_handler.rb:75:in `handle_abort'  
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/vendor/deps/cli-kit/lib/cli/kit/error_handler.rb:21:in `call'
  C:/Ruby27-x64/lib/ruby/gems/2.7.0/gems/shopify-cli-2.0.1/bin/shopify:32:in `<main>'

Template: templates/page.gem-15505752106-template.liquid
Node: Liquid::Variable
Markup:

Check options: {}
Theme Check Version: 1.0.0
Ruby Version: 2.7.3
Platform: x64-mingw32
Muffin mode: activated

Whoops! It looks like you found a bug in Theme Check.
Please report it at https://github.com/Shopify/theme-check/issues, and include the message above.
Or cross your fingers real hard, and try again.`

Got this error in the console when running shopify theme check on the site using the GemPages app.
@macournoyer
Copy link
Contributor

Hi @AngelikaBlend! Thanks for reporting this.

Can you send me the content of your templates/page.gem-15505752106-template.liquid template. Either here, or via email if you prefer: [email protected]

macournoyer added a commit that referenced this issue Jul 6, 2021
@macournoyer
Ignore empty {{}} in SpaceInsideBraces
f843c00 
Fixes #348
@macournoyer macournoyer self-assigned this Jul 6, 2021
@macournoyer macournoyer mentioned this issue Jul 6, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@macournoyer macournoyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore empty {{}} in SpaceInsideBraces Shopify/theme-check
2 participants
@macournoyer @AngelikaBlend