Fix UnusedAssign false positives from {% render ... with var %}

Fixes #582
Shopify · Jul 18, 2022 · 63d00e1 · 63d00e1
1 parent c361f54
commit 63d00e1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/theme_check/tags.rb b/lib/theme_check/tags.rb
@@ -145,7 +145,7 @@ class Render < Liquid::Tag
 
       disable_tags "include"
 
-      attr_reader :template_name_expr, :attributes
+      attr_reader :template_name_expr, :variable_name_expr, :attributes
 
       def initialize(tag_name, markup, options)
         super
@@ -171,6 +171,7 @@ class ParseTreeVisitor < Liquid::ParseTreeVisitor
         def children
           [
             @node.template_name_expr,
+            @node.variable_name_expr,
           ] + @node.attributes.values
         end
       end

diff --git a/test/checks/unused_assign_test.rb b/test/checks/unused_assign_test.rb
@@ -24,6 +24,8 @@ def test_do_not_report_used_assigns
         {{ 'a' | t: b }}
         {% assign c = 1 %}
         {{ 'a' | t: tags: c }}
+        {% assign d = 1 %}
+        {% render 'foo' with d %}
       END
     )
     assert_offenses("", offenses)