Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use requires_ancestor instead of T.unsafe(self) #83

Merged
merged 1 commit into from
May 4, 2021
Merged

Use requires_ancestor instead of T.unsafe(self) #83

merged 1 commit into from
May 4, 2021

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented May 4, 2021

The Cli::Helper actually depends on Thor.

@Morriar Morriar requested a review from a team May 4, 2021 20:10
@Morriar Morriar changed the title Use requires_ancestor instead of T.unsafe(self). Use requires_ancestor instead of T.unsafe(self) May 4, 2021
@Morriar Morriar merged commit 3e223af into master May 4, 2021
@Morriar Morriar deleted the at-ra branch May 4, 2021 20:40
@shopify-shipit shopify-shipit bot temporarily deployed to production July 28, 2021 15:30 Inactive
@Morriar Morriar added the chore Chore task label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock approved these changes

@mutecipher mutecipher mutecipher approved these changes

Assignees
No one assigned
Labels
chore Chore task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Morriar @mutecipher @vinistock