Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean dead code analysis following migration to Model #567

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Clean dead code analysis following migration to Model #567

merged 5 commits into from
Jun 20, 2024

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Jun 19, 2024

This PR cleans a bunch of leftovers following #562, #563, #564, #565 and #566:

  1. Do not instantiate plugins when loading them (6944c93)
  2. Initialize plugins with Index (98ad709)
  3. Move reference creation to Index (8035cc4)
  4. Do not pass indexer to plugin on_send (108d6fd)
  5. Do not pass the Deadcode::Definition to plugins on_define_* methods (e740685)

No functional changes, this PR is easier to review commit by commit.

@Morriar Morriar added the chore Chore task label Jun 19, 2024
@Morriar Morriar self-assigned this Jun 19, 2024
@Morriar Morriar requested a review from a team as a code owner June 19, 2024 22:42
@Morriar Morriar requested review from egiurleo and KaanOzkan June 19, 2024 22:42
shioyama
shioyama approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@shioyama shioyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I can review here, but since I'm getting to know this codebase feels like reviewing these PRs is a good way to start.

Anyway this LGTM! 👍

@Morriar Morriar force-pushed the at-model-deadcode-attrs branch from fea73f3 to 45bfaf1 Compare June 20, 2024 14:28
@Morriar Morriar force-pushed the at-model-deadcode branch from e740685 to e5fe37c Compare June 20, 2024 14:28
Base automatically changed from at-model-deadcode-attrs to main June 20, 2024 17:21
@Morriar Morriar merged commit ae242f5 into main Jun 20, 2024
8 checks passed
@Morriar Morriar deleted the at-model-deadcode branch June 20, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shioyama shioyama shioyama approved these changes

@egiurleo egiurleo Awaiting requested review from egiurleo egiurleo is a code owner automatically assigned from Shopify/sorbet

@KaanOzkan KaanOzkan Awaiting requested review from KaanOzkan KaanOzkan is a code owner automatically assigned from Shopify/sorbet

Assignees

@Morriar Morriar

Labels
chore Chore task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Morriar @shioyama