Use improved libprism source to build Prism without dependency on Ruby #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
force-pushed
the
build-with-better-packaged-prism-release
branch
2 times, most recently
from
e4005ba to
8d8f0bd
Compare
Closed
st0012
force-pushed
the
build-with-better-packaged-prism-release
branch
2 times, most recently
from
64db338 to
d75e6b1
Compare
st0012
changed the title
The main blocker for upstreaming Prism parser to Sorbet is that we currently rely on Ruby to build Prism, as its required by Prism's `rake template` task. But by package the files generated by `rake template` in Prim's release, we will be able to remove the dependency on Ruby while significantly simplify the build configurations for Prism.
st0012
force-pushed
the
build-with-better-packaged-prism-release
branch
from
d75e6b1 to
ac6e9a0
Compare
amomchilov
approved these changes
Jan 10, 2025
| @@ -5,9 +5,6 @@ on: | |||
| branches: [prism] | |||
| pull_request: | |||
| branches: [prism] | |||
| env: | |||
| RUBY_ROOT: '/opt/hostedtoolcache/Ruby/3.3.0/x64' | |||
egiurleo
approved these changes
Jan 13, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The main blocker for upstreaming Prism parser to Sorbet is that we currently rely on Ruby to build Prism, as its required by Prism's
rake templatetask.But if we can package the files generated by
rake templatein Prim's release (PR), we will be able remove the dependency on Ruby while significantly simplify the build configurations for Prism.Test plan
See included automated tests.