Implement Prism -> Sorbet translation for pinning patterns #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
commented
Oct 10, 2024
There was a problem hiding this comment.
Adding the lvar = 123 made this whole thing get wrapped into a Begin and get super indented. I suggest reviewing with "Hide whitespace" enabled.
amomchilov
force-pushed
the
Alex/translate-pattern-vars
branch
from
2fbe063 to
ee10af4
Compare
amomchilov
force-pushed
the
Alex/translate-variable-pinning
branch
from
afee130 to
de3a00b
Compare
egiurleo
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #150
Closes #151
Builds on top of #275