This repository has been archived by the owner on Nov 15, 2017. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
The
package-lock.json
andnpm-shrinkwrap.json
files were added to the gitignore because it was believed these should stay out of the repo.The
package-lock.json
is supposed to be committed to repos. From the file's description on npmjs.org https://docs.npmjs.com/files/package-lock.json#descriptionAs for the
npm-shrinkwrap.json
: we're not currently including one and have no immediate plans to. But it should not be ignored from the project.Checklist
For contributors:
For maintainers:
package.json
version in a separate PR, if applicable.