Skip to content
This repository has been archived by the owner on Nov 15, 2017. It is now read-only.

allow certain npm files #76

Merged
merged 1 commit into from
Jul 18, 2017
Merged

allow certain npm files #76

merged 1 commit into from
Jul 18, 2017

Conversation

NathanPJF
Copy link
Contributor

@NathanPJF NathanPJF commented Jul 18, 2017

What are you trying to accomplish with this PR?

The package-lock.json and npm-shrinkwrap.json files were added to the gitignore because it was believed these should stay out of the repo.

The package-lock.json is supposed to be committed to repos. From the file's description on npmjs.org https://docs.npmjs.com/files/package-lock.json#description

It describes the exact tree that was generated, such that subsequent installs are able to generate identical trees, regardless of intermediate dependency updates. This file is intended to be committed into source repositories, and serves various purposes

As for the npm-shrinkwrap.json: we're not currently including one and have no immediate plans to. But it should not be ignored from the project.

Checklist

For contributors:

For maintainers:

  • I have 🎩'd these changes.
  • I have bumped the package.json version in a separate PR, if applicable.

@NathanPJF NathanPJF requested a review from bertiful July 18, 2017 21:16
Copy link
Contributor

@bertiful bertiful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@NathanPJF NathanPJF merged commit 106e44e into master Jul 18, 2017
@NathanPJF NathanPJF deleted the edit-gitignore branch July 18, 2017 21:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants