Skip to content
This repository has been archived by the owner on Nov 15, 2017. It is now read-only.

Fix slate test command passing on Circle CI #72

Merged
merged 1 commit into from
Jul 5, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/tasks/includes/lint-reporter.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
const gutil = require('gulp-util');
const _ = require('lodash');

const messages = require('./messages.js');

/** Class representing a custom reporter for @shopify/theme-lint */
export default class Reporter {
constructor() {
Expand Down Expand Up @@ -53,6 +55,8 @@ export default class Reporter {
return gutil.log(failure[0]);
});
});

throw new Error(messages.translationsFailed());
}

this.successes = this.failures = [];
Expand Down
4 changes: 4 additions & 0 deletions src/tasks/includes/messages.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@ const messages = {
' and run a full <slate deploy> as a result.';
},

translationsFailed: () => {
return 'Translation errors detected.';
},

invalidThemeId: (themeId, env) => {
gutil.log('Invalid theme id for',
gutil.colors.cyan(`${env}: ${themeId}`),
Expand Down