This repository has been archived by the owner on Nov 15, 2017. It is now read-only.
Upgrade require-dir to 0.3.2 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes slate CLI command failures on Node v8.
NathanPJF
approved these changes
Jun 16, 2017
There was a problem hiding this comment.
Thanks for both identifying the issue and submitting this PR, @alistairholt
I've 🎩 the changes in a couple versions of node - works great 👍
|
@NathanPJF no problem. Glad to help. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes slate CLI command failures on Node v8.
What are you trying to accomplish with this PR?
Fixes issue #170 in slate. See issue #45 in requireDir for details of the fix introduced in 0.3.2.
Checklist
For contributors:
For maintainers:
package.jsonversion in a separate PR, if applicable.