Remove support for rails 4 #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hammadk
force-pushed
the
remove-support-for-rails-4
branch
from
a5b46da to
6b2ef33
Compare
SebastianSzturo
approved these changes
May 28, 2017
|
Sub @swalkinshaw for @kevinhughes27 since Kevin is away. Scott, please see the comments in this thread for context on why we are removing support for Rails 5). |
swalkinshaw
reviewed
May 29, 2017
.travis.yml
Outdated
| @@ -6,5 +6,4 @@ rvm: | |||
| - 2.3.1 | |||
|
|
|||
| gemfile: | |||
| - Gemfile.rails40 | |||
| - Gemfile.rails50 | |||
| - Gemfile | |||
There was a problem hiding this comment.
Is this even needed anymore?
There was a problem hiding this comment.
We didn't need that. Removed 👍
|
Oh, can you update https://github.com/Shopify/shopify_app#rails-5 |
|
Awesome! Thanks for doing this :) |
|
Shouldn't this have been released as gem 'shopify_app', '~> 7.2.0' |
|
Fair point Ashmaroli. We should have skipped to On the bright side, bundler will complain and let them know if their app is using Rails < 5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to remove support for Rails 4 because changes to the testing syntax In Rails 5 are not compatible with this version.
This PR makes the following changes: