Remove script tag manager #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Unrelated, but the link
[Upgrading to `v22.0.0`](#upgrading-to-v2020)
is pointing to the wrong anchor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Removes
ScripttagManagerDeprecation Messaging Error
We realize there was a communication error in messaging where deprecation logs messaged this resources would be
deprecatedin version 22 notdeleted. Given this log as been sounding off for two years now we felt that we should remove it rather than punting for the next major release.We apologize for the confusion this caused and you find yourself affected. Refer to the upgrading doc for instructions on how reimplement this functionality if you find yourself in the position of needing to upgrade to the latest version of this gem while still using the script tag manager.
Reviewer's guide to testing
Installed on a local app with a dev store to ensure no errors were raised.
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary