Fix InMemoryUserSessionStore - user.shopify_user_id does not exist #1716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Using
ShopifyApp
gem'sInMemoryUserSessionStore
doesn't work out of the boxshopify_user_id
does not belong inShopifyAPI::Auth::AssociatedUser
, usingid
instead.Added test around
InMemoryUserSessionStore
as well.Reviewer's guide to testing
Set configuration user session repository to use
InMemoryUserSessionStore
, see that it fails before this fix, and can store sessions after this fix.Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.md
if the changes would impact usersREADME.md
, if appropriate./docs
, if necessary