Don't redirect on mismatching scopes if configuration is disabled #1639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This skips the redirect-to-reauthenticate block in
LoginProtection
We had an incident earlier this week where we were doing a scope upgrade and despite us disabling
reauth_on_access_scope_changes
ahead of time.The scopes were updated/backfilled on the Shopify Core side, but since the cached scopes in
user
andshop
models were a subset of the actually-approved scopes in Core requests were rejected with a401
response without even sending them to Core.This was surprising behaviour to us since we'd disabled the feature intentionally ahead of time.
Reviewer's guide to testing
user
andshop
modelsconfig.scope
)reauth_on_access_scope_changes = false
in your app'sshopify_app
initializerChecklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.md
if the changes would impact usersREADME.md
, if appropriate./docs
, if necessary