allow trusted shopify domains when sanitizing #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teddyhwang
approved these changes
Dec 12, 2022
nelsonwittwer
force-pushed
the
nelsonwittwer/unified_admin
branch
from
868ce0f to
b635e8a
Compare
fabriazza
pushed a commit
to fabriazza/shopify_app
that referenced
this pull request
Feb 1, 2023
* allow trusted shopify domains when sanitizing * better tests for trusting sanitized domains * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
As Shopify rolls out a new unified admin experience, we can expect to see stores use
admin.shopify.cominstead of what they had configured inmyshopify_domain(which typically defaults tomyshopify.com).This PR will trust Shopify domains even if they differ from what the app has configured on their
myshopify_domainconfiguration.Reviewer's guide to testing
Should still be able to install app using this gem.
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary