Add session argument in ShopifyApp::WebhooksManager.destroy_webhooks #1569
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Closes: #1568
When
ShopifyApp::WebhooksManager.recreate_webhooks!
is executed, it occurs bellow error.I think the reason the error occurred is ShopifyApp::WebhooksManager.recreate_webhooks! calls
destroy_webhooks
in it and calls ShopifyAPI::Webhooks::Registry.unregister in destroy_webhooks method.But, destroy_webhooks doesn't receive any arguments, and it doesn't pass a session argument to unregister method.
So, This PR adds a session argument in destroy_webhooks method and passes it in recreate_webhooks!
Also, I add tests for destroy_webhooks because there aren't tests.
Things to focus on
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.md
if the changes would impact usersUpdateREADME.md
, if appropriate.Update any relevant pages in/docs
, if necessaryFor security fixes, the Disclosure Policy must be followed.Please review them.
Thanks