Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure offline and online tokens are fetched via available auth hash #1151

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Ensure offline and online tokens are fetched via available auth hash #1151

merged 1 commit into from
Jan 20, 2021

Conversation

rezaansyed
Copy link
Contributor

@rezaansyed rezaansyed commented Jan 19, 2021 •
edited
Loading

Fixes #1128

We have noticed that the callback controller was fetching a token based on the session object for post perform jobs. This is not necessary as the offline and/or online tokens can be retrieved via the auth hash.

Before submitting the PR, please consider if any of the following are needed:

  • Update CHANGELOG.md if the changes would impact users
  • Update README.md, if appropriate.
  • Update any relevant pages in docs/, if necessary
  • For security fixes, the Disclosure Policy must be followed.

@rezaansyed rezaansyed requested a review from a team as a code owner January 19, 2021 20:49
@rezaansyed rezaansyed self-assigned this Jan 19, 2021
@rezaansyed rezaansyed force-pushed the fix-failing-post-perform-jobs branch from 6c2f28b to 0707d5f Compare January 19, 2021 20:55
@resistorsoftware
Copy link

Thanks for this. Took care of the problem nicely.

tanema
tanema approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@tanema tanema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@rezaansyed rezaansyed force-pushed the fix-failing-post-perform-jobs branch from 0707d5f to 4cc2614 Compare January 19, 2021 22:13
@rezaansyed rezaansyed force-pushed the fix-failing-post-perform-jobs branch from 4cc2614 to d779e0a Compare January 19, 2021 22:24
greatestape
greatestape approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@greatestape greatestape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rezaansyed rezaansyed merged commit 88f42f0 into master Jan 20, 2021
@rezaansyed rezaansyed deleted the fix-failing-post-perform-jobs branch January 20, 2021 14:54
@rezaansyed rezaansyed mentioned this pull request Jan 20, 2021
Merged
4 tasks
@rezaansyed rezaansyed temporarily deployed to rubygems January 20, 2021 16:17 Inactive
@macdonaldr93 macdonaldr93 mentioned this pull request Mar 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@resistorsoftware resistorsoftware resistorsoftware left review comments

@tanema tanema tanema approved these changes

@greatestape greatestape greatestape approved these changes

@ragalie ragalie Awaiting requested review from ragalie

@alexaitken alexaitken Awaiting requested review from alexaitken

@theundeadmonk theundeadmonk Awaiting requested review from theundeadmonk

Assignees

@NabeelAhsen NabeelAhsen

@rezaansyed rezaansyed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configuring the script tags is causing errors
5 participants
@rezaansyed @resistorsoftware @greatestape @tanema @NabeelAhsen