Skip to content

Commit

Permalink
Merge pull request #1924 from Shopify/drop_warning
Browse files Browse the repository at this point in the history
Drop log_v23_deprecations console warning
  • Loading branch information
tamcgoey authored Dec 18, 2024
2 parents f9a8683 + 831c029 commit 2dd9feb
Showing 1 changed file with 0 additions and 21 deletions.
21 changes: 0 additions & 21 deletions lib/shopify_app/configuration.rb
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ def initialize
@webhooks_manager_queue_name = Rails.application.config.active_job.queue_name
@disable_webpacker = ENV["SHOPIFY_APP_DISABLE_WEBPACKER"].present?
@scope = []

log_v23_deprecations
end

def login_url
Expand Down Expand Up @@ -165,25 +163,6 @@ def post_authenticate_tasks
task_class
end
end

private

def log_v23_deprecations
return unless Rails.env.development?

# TODO: Remove this before releasing v23.0.0
message = <<~EOS
================================================
=> Upcoming changes in v23.0:
* 'CallbackController::perform_after_authenticate_job' and related methods 'install_webhooks', 'perform_after_authenticate_job'
* are deprecated and will be removed from CallbackController in the next major release. If you need to customize
* post authentication tasks, see https://github.com/Shopify/shopify_app/blob/main/docs/shopify_app/authentication.md#post-authenticate-tasks
* ShopifyApp::JWTMiddleware will be removed, use ShopifyApp::WithShopifyIdToken instead.
================================================
EOS
puts message
end
end

class BillingConfiguration
Expand Down

0 comments on commit 2dd9feb

Please sign in to comment.