Policial fixes

Shopify · Jul 2, 2019 · 0bc124b · 0bc124b
1 parent d1fb114
commit 0bc124b
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 13 deletions.
diff --git a/app/controllers/shopify_app/callback_controller.rb b/app/controllers/shopify_app/callback_controller.rb
@@ -15,7 +15,7 @@ def callback
         redirect_to return_address
       else
         flash[:error] = I18n.t('could_not_log_in')
-        redirect_to login_url_with_optional_shop
+        redirect_to(login_url_with_optional_shop)
       end
     end
 

diff --git a/app/controllers/shopify_app/sessions_controller.rb b/app/controllers/shopify_app/sessions_controller.rb
@@ -45,7 +45,7 @@ def granted_storage_access
     def destroy
       reset_session
       flash[:notice] = I18n.t('.logged_out')
-      redirect_to login_url_with_optional_shop
+      redirect_to(login_url_with_optional_shop)
     end
 
     private
@@ -110,7 +110,7 @@ def authenticate_in_context
     end
 
     def authenticate_at_top_level
-      fullpage_redirect_to login_url_with_optional_shop(top_level: true)
+      fullpage_redirect_to(login_url_with_optional_shop(top_level: true))
     end
 
     def authenticate_in_context?
@@ -128,14 +128,18 @@ def request_storage_access?
     end
 
     def redirect_to_request_storage_access
-      render :request_storage_access, layout: false, locals: {
-        does_not_have_storage_access_url: top_level_interaction_path(
-          shop: sanitized_shop_name
-        ),
-        has_storage_access_url: login_url_with_optional_shop(top_level: true),
-        app_home_url: granted_storage_access_path(shop: sanitized_shop_name),
-        current_shopify_domain: current_shopify_domain
-      }
+      render(
+        :request_storage_access,
+        layout: false,
+        locals: {
+          does_not_have_storage_access_url: top_level_interaction_path(
+            shop: sanitized_shop_name
+          ),
+          has_storage_access_url: login_url_with_optional_shop(top_level: true),
+          app_home_url: granted_storage_access_path(shop: sanitized_shop_name),
+          current_shopify_domain: current_shopify_domain,
+        }
+      )
     end
   end
 end
diff --git a/lib/shopify_app/controller_concerns/login_protection.rb b/lib/shopify_app/controller_concerns/login_protection.rb
@@ -47,13 +47,13 @@ def redirect_to_login
         if request.get?
           session[:return_to] = "#{request.path}?#{sanitized_params.to_query}"
         end
-        redirect_to login_url_with_optional_shop
+        redirect_to(login_url_with_optional_shop)
       end
     end
 
     def close_session
       clear_shop_session
-      redirect_to login_url_with_optional_shop
+      redirect_to(login_url_with_optional_shop)
     end
 
     def clear_shop_session