Fixes to_hash to include readonly attributes
#941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkevinosullivan
force-pushed
the
kos/fix930_variant_tohash_include_inventory_quantity
branch
from
a49146f to
143c24d
Compare
eliasrumley
reviewed
Apr 22, 2022
eliasrumley
approved these changes
Apr 22, 2022
mkevinosullivan
force-pushed
the
kos/fix930_variant_tohash_include_inventory_quantity
branch
from
143c24d to
3cb802b
Compare
Adds parameter to `to_hash` so that default behaviour includes readonly attributes; setting the parameter to `true` indicates that `to_hash` is being used to serialize the object for saving (and thus excludes readonly attributes). Fixes issue #930
mkevinosullivan
force-pushed
the
kos/fix930_variant_tohash_include_inventory_quantity
branch
from
3cb802b to
8b3b27a
Compare
mkevinosullivan
force-pushed
the
kos/fix930_variant_tohash_include_inventory_quantity
branch
from
9e8dc97 to
31dea0a
Compare
mkevinosullivan
force-pushed
the
kos/fix930_variant_tohash_include_inventory_quantity
branch
from
31dea0a to
3634cf7
Compare
mkevinosullivan
deleted the
kos/fix930_variant_tohash_include_inventory_quantity
branch
This was referenced May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #930
Adds parameter to
to_hashso that default behaviour includes readonly attributes; setting the parameter totrueindicates thatto_hashis being used to serialize the object for saving (and thus excludes readonly attributes).How has this been tested?
Added tests to verify that readonly attributes are included when using the default
to_hashand excluded when usingto_hash(true)(i.e,saving = true).Checklist: