Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra curly brace from graphql query for Webhooks.get_webhook_id method #933

Merged
merged 4 commits into from
Apr 28, 2022

Conversation

JiaboHou
Copy link
Contributor

@JiaboHou JiaboHou commented Apr 20, 2022

Description

Removes an extra curly brace in the query for ShopifyAPI::Webhooks::Registry.get_webhook_id. When calling the unregister method by using ShopifyApp::WebhooksManager from the shopify_app gem I would get the following error:

ShopifyAPI::Errors::WebhookRegistrationError: Failed to fetch webhook from Shopify: Parse error on "}" (RCURLY) at [10, 1]
/Users/jiabo/src/github.com/Shopify/shopify-bids/lib/tasks/shopify_shops.rake:31:in `block in destroy_webhooks'

Which I believe is due to the extra closing bracket in the query.

How has this been tested?

I added unit tests for get_webhook_id, as well as tested this ]manually by specifying this branch as part of my Gemfile.

Checklist:

  • My commit message follow the pattern described in here
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the project documentation. N/A
  • I have added a changelog line.

@JiaboHou JiaboHou requested a review from a team as a code owner April 20, 2022 03:08
@JiaboHou JiaboHou force-pushed the JiaboHou/fix-webhook-query branch from 5132063 to 6e69da8 Compare April 20, 2022 03:09
@JiaboHou JiaboHou force-pushed the JiaboHou/fix-webhook-query branch from 6e69da8 to 3750190 Compare April 22, 2022 16:23
@mkevinosullivan mkevinosullivan merged commit 5c6a907 into main Apr 28, 2022
@mkevinosullivan mkevinosullivan deleted the JiaboHou/fix-webhook-query branch April 28, 2022 20:04
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems May 18, 2022 16:29 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems July 4, 2022 16:27 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants