Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add save deny list to base REST resource #919

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Add save deny list to base REST resource #919

merged 2 commits into from
Apr 7, 2022

Conversation

paulomarg
Copy link
Contributor

WHY are these changes introduced?

Some REST resources (currently only the Variant one) may throw errors if certain fields are included in PUT / POST requests.

WHAT is this pull request doing?

This PR adds support for the resources to exclude arbitrary fields when saving data.

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change

@paulomarg paulomarg requested a review from a team as a code owner April 6, 2022 17:42
@paulomarg paulomarg force-pushed the skip_readonly_attributes branch from ae26907 to 90ff178 Compare April 6, 2022 17:42
mllemango
mllemango approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@mllemango mllemango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: is save_deny_list more understandable or is read_only_list more understandable? :D

@paulomarg
Copy link
Contributor Author

paulomarg commented Apr 7, 2022 •
edited
Loading

I was on the fence about that as well. I'll make it read_only_attributes then! if you're happy with it I'll merge 🙂

@paulomarg paulomarg requested a review from mllemango April 7, 2022 18:12
@paulomarg paulomarg merged commit 8525bdb into main Apr 7, 2022
@paulomarg paulomarg deleted the skip_readonly_attributes branch April 7, 2022 18:33
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems April 11, 2022 17:32 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teddyhwang teddyhwang teddyhwang approved these changes

@mllemango mllemango Awaiting requested review from mllemango

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulomarg @teddyhwang @mllemango