warning raised for version eol #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @Shopify/api-patterns-team |
swalkinshaw
reviewed
Feb 19, 2020
grcooper
approved these changes
Feb 19, 2020
toneymathews
force-pushed
the
warn-on-warning-header
branch
from
85a969e to
37e4a44
Compare
katiedavis
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Shopify/shopify/issues/233879
TL;DR This pull request is raised to add a warning message case of API Version being used to make a call is expired or will expire within 30 days
Background:
Currently, a warning header is added to the responses of all admin and storefront APIs that are using a version that expires within 30 days or is expired already. This was done through https://github.com/Shopify/shopify/pull/232580
Now, we want to raise warning messages through the Shopify API gem as well if API calls are made using expired or EOL versions.
Solution
The response headers of the API responses are checked for the presence of the version EOL warning header. If present, a warning message is raised.