Add locations_for_move API #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmakaze
reviewed
Jan 17, 2020
test/fixtures/locations.json
Outdated
| }, | ||
| "message": "Current location.", | ||
| "movable": false | ||
| }, |
There was a problem hiding this comment.
This fixture isn't just locations, it includes some movable info. Better named fulfillment_order_move_locations
karmakaze
reviewed
Jan 17, 2020
linzhao125
force-pushed
the
location_to_move
branch
from
61cac8c to
b6f4195
Compare
karmakaze
reviewed
Jan 20, 2020
|
|
||
| location = location_for_move.location | ||
| assert location.is_a?(ShopifyAPI::Location) | ||
| assert_equal 1059367776,location.id |
karmakaze
reviewed
Jan 20, 2020
| @@ -17,6 +17,14 @@ def fulfillments(options = {}) | |||
| fulfillment_hashes.map { |fulfillment_hash| Fulfillment.new(fulfillment_hash) } | |||
| end | |||
|
|
|||
| def locations_for_move(options = {}) | |||
There was a problem hiding this comment.
What could be passed in as options? Could add a test for it.
There was a problem hiding this comment.
Actually, there is no options. I will remove it.
linzhao125
force-pushed
the
location_to_move
branch
from
b6f4195 to
876e7cc
Compare
karmakaze
approved these changes
Jan 20, 2020
tanema
approved these changes
Jan 20, 2020
linzhao125
force-pushed
the
location_to_move
branch
from
876e7cc to
daca0cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/Shopify/shopify/issues/211513
This PR is to implement the API for REST API:
GET fulfillment_orders/:fulfillment_order_id/locations_for_move