Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change webhook handler deprecation version #1290

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Change webhook handler deprecation version #1290

merged 3 commits into from
Mar 12, 2024

Conversation

lizkenyon
Copy link
Contributor

@lizkenyon lizkenyon commented Mar 12, 2024 •
edited
Loading

Description

We have uncovered two issues with the last release

  • We marked the new webhook handler to throw errors at the next major release (14.0.0.) but then we immediatley released version 14. Meaning we started throwing errors before giving a chance to updgrade. We move this deprecation to the next major version

  • There seems to be some issues importing the new handler files. This is caused by zeitwork, this has happened before, and the resolution has been importing it in the shopify_api.rb

How has this been tested?

  • This has been tested with a local test app.

Checklist:

  • [] My commit message follow the pattern described in here
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the project documentation.
  • I have added a changelog line.

@lizkenyon
We never did a minor release before we released this
3b78ef5 
We need to give a window before we start sending errors
@lizkenyon lizkenyon requested a review from a team as a code owner March 12, 2024 14:42
nelsonwittwer
nelsonwittwer approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@nelsonwittwer nelsonwittwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gucci!

@lizkenyon lizkenyon merged commit 37cbb3e into main Mar 12, 2024
5 checks passed
@lizkenyon lizkenyon deleted the liz/move-webhook-handle-version branch March 12, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulomarg paulomarg paulomarg approved these changes

@nelsonwittwer nelsonwittwer nelsonwittwer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lizkenyon @nelsonwittwer @paulomarg