Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FeatureDeprecatedError being raised without a message #1288

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

brendo
Copy link
Contributor

@brendo brendo commented Mar 11, 2024

Description

The FeatureDeprecatedError error is currently raised without a message. This makes it near impossible to know what the feature was that was deprecated and leads to a lot of diving through stacktraces to try and figure it out.

Screenshot 2024-03-12 at 8 41 04 am

This PR goes a little way to making this better by specifying the message when raising the error. This should give developers more clues and speed up investigation.

How has this been tested?

Updated existing unit test.

Checklist:

  • My commit message follow the pattern described in here
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the project documentation.
  • I have added a changelog line.

@brendo brendo requested a review from nelsonwittwer March 11, 2024 22:47
@brendo brendo requested a review from a team as a code owner March 11, 2024 22:47
@brendo brendo force-pushed the fix_deprecated-error-not-having-message branch from c9007c9 to 0eca540 Compare March 11, 2024 22:48
Copy link
Contributor

@paulomarg paulomarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@paulomarg paulomarg merged commit a5be9f7 into main Mar 12, 2024
5 checks passed
@paulomarg paulomarg deleted the fix_deprecated-error-not-having-message branch March 12, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants