Add expired? method to check if session is expired #1244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the problem it is solving?
There isn't currently a method available to check if an auth session is expired (for online tokens mainly). It's up to each app to implement the method if they want to do such check. This PR adds an
expired?
method to theSession
that will check theexpires
attribute if it exists.What is the context of these changes?
We are planning to add a check on the expiry date in
shopify_app
to trigger an early re-auth, and having that method will make the check cleanerWhat is the impact of this PR?
A new method can be used to check if the session is expired. No impact as long as it's not used
How has this been tested?
Unit tests provided in the PR
Checklist: