Use ShopifyAPI::Clients::HttpClient instead of HTTParty directly in OAuth.validate_auth_callback #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendo
force-pushed
the
chore_use-http-client-in-auth-client
branch
from
dd6dc9d to
0868c16
Compare
There was a problem hiding this comment.
I like that we are using our client here as well! I'd feel better approving this if I knew it was testing on an application that demonstrated it was still able to be installed/authenticated with a test app. It sounds like only unit tests have been used for testing thus far.
brendo
force-pushed
the
chore_use-http-client-in-auth-client
branch
from
0868c16 to
b81d483
Compare
nelsonwittwer
approved these changes
Nov 8, 2023
garethson
pushed a commit
to garethson/shopify-api-ruby
that referenced
this pull request
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: #1235
Description
This PR replaces a direct call to HTTParty with the HttpClient included by this library. Whilst this doesn't change much from a consumer's perspective, internally it means a monkey patch on HttpClient to use the internal domain covers all HTTP requests originating from this library.
How has this been tested?
At the moment, just the unit tests in this project.
Checklist: