-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip mandatory webhook topics during registration/unregistration #1237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
I think this breaks webhooks processing for mandatory webhooks. shopify-api-ruby/lib/shopify_api/webhooks/registry.rb Lines 179 to 183 in 82e4caf
The shopify-api-ruby/lib/shopify_api/webhooks/registry.rb Lines 25 to 27 in 82e4caf
|
Yep, I can confirm that too. Mandatory webhooks in v13.3.0 are broken. Please rollback this PR. |
Fixed with #1249 |
Thanks for the quick fix! 🙏 |
…pify#1237) * Do not allow registration to mandatory webhooks * skip unregister calls for mandatory webhooks * changelog
Description
Friction with mandatory webhooks was identified in the shopify app gem. Since Mandatory webhooks aren't subscribed to via API, we need to gracefully skip them during registrations without breaking handlers.
This skips registration/unregistration for mandatory topics that are managed in the partner dashboard
How has this been tested?
Unit tests within this library. I've also created a new app using our ruby app template pointing to this branch and my fix to the app gem's branch to verify I could recreate webhook without error.
Checklist: