Convert json_response_body_names to array #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mllemango
force-pushed
the
melaniew/custom-json-body-names-to-array
branch
from
af2a839 to
17c1848
Compare
zzooeeyy
reviewed
Aug 31, 2023
| session: @session, instance: self | ||
| ) | ||
| response_name = self.class.json_response_body_names & response.body.keys | ||
| self.class.create_instance(data: response.body[response_name.first], session: @session, instance: self) |
There was a problem hiding this comment.
Is there any risk for response.body.keys not containing any of the json_response_body_names?
There was a problem hiding this comment.
there is, but no riskier than the previous code, sorbet would throw the nil error
zzooeeyy
reviewed
Aug 31, 2023
zzooeeyy
approved these changes
Sep 1, 2023
mllemango
force-pushed
the
melaniew/custom-json-body-names-to-array
branch
from
368b9cb to
37120da
Compare
mllemango
force-pushed
the
melaniew/custom-json-body-names-to-array
branch
from
37120da to
07de972
Compare
garethson
pushed a commit
to garethson/shopify-api-ruby
that referenced
this pull request
Dec 1, 2023
* Convert json_response_body_names to array to allow multiple names * Fix customer address all not returning repsonse * Remove failing tests * Add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1018
Fixes #1190
Allowing multiple response body names to be passed in so we can check and build a response based on what key matches the for the class
How has this been tested?
Created a fresh app and pre-populated test store and made sure we can create a fulfillment request without sorbet error
Get a response back from CustomerAddress.all
Checklist:
I have updated the project documentation.