Add T::Array[String] support for webhook fields #1189
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the sorbet signature for the
Webhooks::Registry
to supportT::Array[String]
.The examples currently described in ShopifyApp above do not work as the following error is encountered:
Parameter 'fields': Expected type T.nilable(String), got type Array with value ["title", "vendor"] (TypeError)
This PR updates the signature to match the underlying registration code which accepts both String and T::Array[String]
https://github.com/Shopify/shopify-api-ruby/blob/77ab36ca816516a677b736a46eec59aeed36a055/lib/shopify_api/webhooks/registration.rb#L24C19-L24C61
How has this been tested?
Added additional tests asserting the behaviour remains unchanged when passing in array.
Checklist: