Ignore read-only attributes when updating through REST resources #1157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up on the changes in this PR #1149. When a resource has read-only attributes and you attempt to call
save
, the update payload would contain an erroneous entry for the read-only attributes with the value ofHashDiff::NO_VALUE
.The root cause of this issue is that the
original_state
contains the read-only attributes, however the lookup of the current resource state withto_hash(true)
strips them out. Performing aleft_diff
hash comparison then yields the resultingHashDiff::NO_VALUE
.The fix I've implemented is to use a copy of the
original_state
hash with read-only attributes removed when performing the comparison to see which attributes to update.How has this been tested?
I've written a new unit test for the base resource and verified it failed as expected prior to implementing the fix.
Checklist: